Skip to content

gosec fixes#41

Merged
gallacher merged 1 commit into
mainfrom
gosec_fixes
Jul 19, 2024
Merged

gosec fixes#41
gallacher merged 1 commit into
mainfrom
gosec_fixes

Conversation

@suryagupta4
Copy link
Copy Markdown
Contributor

@suryagupta4 suryagupta4 commented Jul 19, 2024 •
edited by abhi16394
Loading

Description

gosec fixes

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran gosec
    image

Unit-test results:
unit-test-gonvme.txt

@suryagupta4 suryagupta4 marked this pull request as ready for review July 19, 2024 11:36
gallacher
gallacher suggested changes Jul 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the unit tests and provide the results.

@gallacher gallacher merged commit 1cdf07f into main Jul 19, 2024
@gallacher gallacher deleted the gosec_fixes branch July 19, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@coulof coulof Awaiting requested review from coulof

@delldubey delldubey Awaiting requested review from delldubey

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@hoppea2 hoppea2 Awaiting requested review from hoppea2

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@nidtara nidtara Awaiting requested review from nidtara

@prablr79 prablr79 Awaiting requested review from prablr79

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@shanmydell shanmydell Awaiting requested review from shanmydell

@tssushma tssushma Awaiting requested review from tssushma

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

@xuluna xuluna Awaiting requested review from xuluna

+3 more reviewers

@alexemc alexemc alexemc approved these changes

@gallacher gallacher gallacher approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suryagupta4 @alexemc @gallacher @shaynafinocchiaro @rishabhatdell