Add ctrl-loss-tmo to connect commands#45
Merged
Conversation
suryagupta4
approved these changes
Oct 14, 2024
lukeatdell
approved these changes
Oct 14, 2024
santhoshatdell
approved these changes
Oct 14, 2024
bharathsreekanth
approved these changes
Oct 14, 2024
shanmydell
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the option ctrl-loss-tmo=-1 so that PowerStore NDUs can take place without impacting the pod volume access. For 1.11.1 we are relying on the user setting this in across the NVMe module but we are asked to support this also in the connect command in case the user did not add the module option. See related GitHub issue 1459.
Also added the GitHub action to run unit tests as part of PR builds.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration