Skip to content

Add ctrl-loss-tmo to connect commands#45

Merged
donatwork merged 3 commits into
mainfrom
1459_powerstore_nvme_tcp
Oct 14, 2024
Merged

Add ctrl-loss-tmo to connect commands#45
donatwork merged 3 commits into
mainfrom
1459_powerstore_nvme_tcp

Conversation

@donatwork
Copy link
Copy Markdown
Contributor

@donatwork donatwork commented Oct 11, 2024

Description

Added the option ctrl-loss-tmo=-1 so that PowerStore NDUs can take place without impacting the pod volume access. For 1.11.1 we are relying on the user setting this in across the NVMe module but we are asked to support this also in the connect command in case the user did not add the module option. See related GitHub issue 1459.

Also added the GitHub action to run unit tests as part of PR builds.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1459

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • The setting was tested int he PowerStore QA labs and verified that pod IO was not interrupted during a NDU.
  • Verified in the kernel/udev state that the ctrl-loss-tmo is being disabled.
  • Tested using cert-csi to validate that provisioning works. Also tested provisioning a pod with 100 volumes.

@donatwork donatwork merged commit 16fef27 into main Oct 14, 2024
@donatwork donatwork deleted the 1459_powerstore_nvme_tcp branch October 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants