Skip to content

Certain version Linux nvme connect CLI contains a typo#76

Merged
ChristianAtDell merged 2 commits into
mainfrom
connnected-or-connected
Mar 18, 2025
Merged

Certain version Linux nvme connect CLI contains a typo#76
ChristianAtDell merged 2 commits into
mainfrom
connnected-or-connected

Conversation

@coulof
Copy link
Copy Markdown
Contributor

@coulof coulof commented Mar 11, 2025

Description

Change the pattern to check if a session is connected

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1845

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Regexp tested here : https://go.dev/play/p/ULjPEOQR0M9

@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gonvme 90.08% (+0.04%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gonvme/gonvme_tcp_fc.go 85.95% (+0.08%) 363 (+2) 312 (+2) 51 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@ChristianAtDell ChristianAtDell merged commit ad76101 into main Mar 18, 2025
@ChristianAtDell ChristianAtDell deleted the connnected-or-connected branch March 18, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants