Fix for upgrade Fails Due to Missing Vault Password File .local_repo_credentials_key During Credential Decryption#4169
Merged
abhishek-sa1 merged 2 commits intodell:pub/q1_devfrom Mar 12, 2026
Conversation
abhishek-sa1
approved these changes
Mar 12, 2026
Rajeshkumar-s2
approved these changes
Mar 12, 2026
| - name: Warn about plaintext copy without key | ||
| ansible.builtin.debug: | ||
| msg: | | ||
| user_registry_credential.yml copied in plaintext (no key present in backup). |
Collaborator
There was a problem hiding this comment.
message should be in vars
| ansible.builtin.debug: | ||
| msg: | | ||
| user_registry_credential.yml was plaintext in backup. | ||
| Copied and encrypted using provided key. |
Collaborator
There was a problem hiding this comment.
move all message to vars
Contributor
Author
There was a problem hiding this comment.
Made the change
| ansible.builtin.copy: | ||
| src: "{{ backup_location }}/.local_repo_credentials_key" | ||
| dest: "{{ input_project_dir }}/.local_repo_credentials_key" | ||
| mode: '0600' |
Collaborator
There was a problem hiding this comment.
move the mode also to vars
| block: | ||
| - name: Copy local_repo_credentials_key from backup (unencrypted case) | ||
| ansible.builtin.copy: | ||
| src: "{{ backup_location }}/.local_repo_credentials_key" |
Collaborator
There was a problem hiding this comment.
use key and file name as variable file as used many places
Contributor
Author
There was a problem hiding this comment.
Made the change
abhishek-sa1
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed redundant decryption logic, added tasks to take care of scenarios where file is decrypted with key present and with key missing