Fix: Add missing additional_json_path parameter for aarch64 build image playbook#4326
Merged
Conversation
Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com>
balajikumaran-c-s
changed the title
abhishek-sa1
approved these changes
Apr 28, 2026
priti-parate
approved these changes
Apr 28, 2026
abhishek-sa1
added a commit
that referenced
this pull request
May 13, 2026
* Update fetch_packages.yml (#4326) Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> * Update feature_request.md Removing project field from Feature request issue template Signed-off-by: Luke Wilson <luke.wilson@dell.com> * Update bug_report.md removing unnecessary entries Signed-off-by: John Lockman <jlockman3@gmail.com> --------- Signed-off-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> Signed-off-by: Luke Wilson <luke.wilson@dell.com> Signed-off-by: John Lockman <jlockman3@gmail.com> Co-authored-by: balajikumaran.cs <balajikumaran.c.s@gmail.com> Co-authored-by: Luke Wilson <luke.wilson@dell.com> Co-authored-by: John Lockman <jlockman3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The 'build_image_aarch64' playbook was not including additional packages from 'additional_packages.json' for compute image roles (slurm_node, login_node, login_compiler_node). Only the base image packages were being added.
Root Cause
The 'image_package_collector' task in 'build_image_aarch64/roles/fetch_packages/tasks/fetch_packages.yml' was missing the 'additional_json_path' parameter, which is required to read and include packages from the additional_packages.json file.
This parameter was present in the x86_64 equivalent but was omitted during the aarch64 implementation.
Fix
Added the missing 'additional_json_path: "{{ additional_json_path }}"' parameter to the 'image_package_collector' task in the aarch64 fetch_packages.yml file.