feat(discovery): robust OME pagination, GPU collection, and timestamped PXE mapping#4349
Merged
Merged
Conversation
…ed PXE mapping - Replace @odata.nextLink-based pagination with explicit $top/$skip OData parameters for deterministic, scalable device retrieval (8k-20k+ nodes) - Add configurable page_size parameter (default 200, max 1000) to ome_server_inventory module and wire through Ansible role defaults - Add retry with exponential backoff for transient HTTP 5xx/timeout failures - Return pagination stats (total_devices, page_size, total_pages, pages_fetched) in module output; display summary in playbook - Collect GPU vendor and type from OME devicePciDevice inventory; append GPU_VENDOR and GPU_TYPE columns to PXE mapping CSV - Generate timestamped PXE mapping files (bmc_pxe_mapping_file_<ts>.csv) so each run produces a unique file - Handle OME returning list instead of dict from inventory endpoints - Fix telemetry_config.yml validation: point to telemetry_validation module instead of removed common_validation.validate_telemetry_config - Add 20 unit tests covering pagination, retry, clamping, and filtering
sujit-jadhav
commented
May 2, 2026
Collaborator
Author
sujit-jadhav
left a comment
sujit-jadhav
left a comment
There was a problem hiding this comment.
OME pagination, GPU collection and timestamped PXE mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OME Pagination
@odata.nextLink-based pagination with explicit$top/$skipOData parameters for deterministic, scalable device retrieval (8k–20k+ nodes)page_sizeparameter (default 200, max 1000) toome_server_inventorymodule and wire through Ansible role defaultsGPU Collection
devicePciDeviceinventoryGPU_VENDORandGPU_TYPEcolumns to PXE mapping CSVTimestamped PXE Mapping
bmc_pxe_mapping_file_<timestamp>.csv) so each run produces a unique fileBug Fixes
telemetry_config.ymlvalidation: point totelemetry_validationmodule instead of removedcommon_validation.validate_telemetry_configTests
Files Changed
common/library/modules/ome_server_inventory.pycommon/library/modules/generate_pxe_mapping.pycommon/library/modules/tests/test_ome_pagination.py(new)common/library/modules/tests/__init__.py(new)common/library/module_utils/input_validation/common_utils/logical_validation.pydiscovery/roles/ome_discovery/defaults/main.ymldiscovery/roles/ome_discovery/tasks/collect_inventory.ymldiscovery/roles/ome_discovery/tasks/generate_pxe_mapping.ymldiscovery/roles/ome_discovery/vars/main.yml