feat: add multi-subnet support for CoreDHCP/coresmd#4352
Merged
Conversation
Add optional additional_subnets configuration under admin_network in network_spec.yml to support multi-RAC / multi-subnet PXE deployments with CoreDHCP relay (giaddr-based routing). Changes: - network_spec.yml: add additional_subnets field with documentation - network_spec.json: JSON schema validation for subnet entries - en_us_validation_msg.py: error messages for subnet validation - provision_validation.py: validate CIDRs, routers, ranges, overlaps - configs.yaml.j2: emit coredhcp_subnets/coredhcp_subnet_pools vars - coredhcp.yaml.j2: dual-mode template (positional args for v0.4.x, key=value format with subnet=/subnet_pool= for multi-subnet) - deploy_openchami.yml: overlay coredhcp template after clone - vars/main.yml: add template path variables - test_additional_subnets_validation.py: 17 unit tests Single-subnet (flat) deployments continue to use the original positional-argument config format compatible with coresmd v0.4.x. Multi-subnet requires coresmd with multi-subnet support (PR #61).
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
abhishek-sa1
approved these changes
May 6, 2026
Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
snarthan
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
additional_subnetsconfiguration underadmin_networkinnetwork_spec.ymlto support multi-RAC / multi-subnet PXE deployments with CoreDHCP relay (giaddr-based routing). Requires coresmd with multi-subnet support (coresmd PR #61).Changes
input/network_spec.ymladditional_subnets: []field with documentation.../schema/network_spec.json.../en_us_validation_msg.py.../provision_validation.py_validate_additional_subnets()+_ranges_overlap()— validates CIDRs, routers within subnet, ranges within subnet, no overlap with admin or between subnets, no DHCP pool overlap.../templates/configs.yaml.j2coredhcp_subnetsandcoredhcp_subnet_poolslists.../templates/coredhcp.yaml.j2.../vars/main.yml.../tasks/deploy_openchami.yml.../tests/test_additional_subnets_validation.pyBackward Compatibility
additional_subnets[](single subnet)[](single subnet)subnet=/subnet_pool=Testing