fix(highlight): carry over bg from treesitter heading hl#16
Merged
Conversation
setup_heading_highlights only copied fg from @markup.heading.<level>.markdown, dropping bg and other attributes. Colorschemes that paint a heading background (e.g. tokyonight defines distinct bg per level) appeared with bg in the source buffer but not in the preview buffer. Now copy the full attribute table from the resolved treesitter hl, so bg, italic, underline, etc. all propagate. bold = true is still forced as a fallback for colorschemes that omit it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_heading_highlightsonly copiedfgfrom@markup.heading.<level>.markdown, silently droppingbg(and other attributes likeitalic/underline).bold = trueis still forced as a fallback for colorschemes that omit it.Verified under tokyonight: all 6
MdRenderH<level>groups now resolve to bothfgandbg(e.g.H3 = fg=#c3e88d bg=#32383f bold=true).Test plan
make test(no behavioral test changes; 515 passed):MdRenderSplitand confirm headings now have a bg matching the source side🤖 Generated with Claude Code