Oracle dsource Creation/Deletion #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop HUBS-2080 | Release Version 3.0.0 | Develop -> Main
ankit-patil-hubs
requested review from
Uddipaan-Hazarika,
arunskurian,
elima-sugunan and
nick-mathison
nick-mathison
previously requested changes
Oct 27, 2023
Contributor
|
Left various documentation comments. Nothing is blocking, but we aren't really clear that the documentation presented is specifically for the Oracle dSource. |
Uddipaan-Hazarika
approved these changes
Oct 31, 2023
Contributor
Uddipaan-Hazarika
left a comment
Uddipaan-Hazarika
left a comment
There was a problem hiding this comment.
On an unrelated topic, I would also suggest to add the unit/integration tests and fix the codeql in this particular PR.
elima-sugunan
approved these changes
Nov 15, 2023
This was referenced Nov 15, 2023
Closed
ankit-patil-hubs
dismissed
nick-mathison’s stale review
Addressed the documentation changes for in oracle dsource md file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Support for Oracle dsource Creation/Deletion
Solution:
Oracle dsource Creation/Deletion
Updated method create/update/delete names to reuse for both appdata and oracle dsource
Testing
Manually tested on oracle rac and non rac setup
(base) ankit.patil@Ankit-Patils-MacBook-Pro terraform-provider-delphix % TF_ACC=1 go test $(go list ./... | grep -v 'vendor') -v -run TestOracleDsource_create_positive -timeout 120m
? terraform-provider-delphix [no test files]
=== RUN TestOracleDsource_create_positive
[DELPHIX] [INFO] 2023/11/01 13:55:25 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:55:31 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:55:36 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:COMPLETED
[DELPHIX] [INFO] 2023/11/01 13:55:36 Job result is COMPLETED
[DELPHIX] [INFO] 2023/11/01 13:55:37 [OK] Breaking poll - Status 200 reached.
[DELPHIX] [INFO] 2023/11/01 13:55:43 [OK] Breaking poll - Status 200 reached.
[DELPHIX] [INFO] 2023/11/01 13:55:48 [OK] Breaking poll - Status 200 reached.
[DELPHIX] [INFO] 2023/11/01 13:56:04 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:56:10 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:56:16 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:56:22 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:56:28 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED
[DELPHIX] [INFO] 2023/11/01 13:56:34 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:COMPLETED
[DELPHIX] [INFO] 2023/11/01 13:56:34 Job result is COMPLETED
[DELPHIX] [INFO] 2023/11/01 13:56:35 [OK] Breaking poll - Status 404 reached.
--- PASS: TestOracleDsource_create_positive (93.81s)
PASS
ok terraform-provider-delphix/internal/provider 95.822s