Revert "DLPX-79034 systemd-networkd releases its DHCP lease on restart (#358)" #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delphix#358)" This reverts commit cfe52e4.
prakashsurya
approved these changes
Feb 4, 2022
grwilson
approved these changes
Feb 4, 2022
sdimitro
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cfe52e4.
This original fix failed. The reason is that the files generated by
netplan applyin/run/systemd/network/...override the configuration created here. A proper fix is to encode this configuration in our netplan yaml itself, and that will be done in http://reviews.delphix.com/r/78103/.