-
Notifications
You must be signed in to change notification settings - Fork 44
DLPX-94112 Additional EFI and systemd-boot packages #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLPX-94112 Additional EFI and systemd-boot packages #507
Conversation
96adff8 to
59d98db
Compare
c64a6b3 to
8b6f581
Compare
8b6f581 to
10c1be4
Compare
10c1be4 to
b9a66e7
Compare
1114b65 to
3bfb97a
Compare
a958a52 to
6888bca
Compare
7867c71 to
e36ce7d
Compare
8ec60ef to
69d31e1
Compare
68f3572 to
3bfb97a
Compare
69d31e1 to
a875c0f
Compare
a875c0f to
1ab2c26
Compare
1ab2c26 to
a44ab34
Compare
|
@tonynguien which of these packages are required to build the relevant packages, and which ones are required to be installed at runtime? The build dependencies should not be present on Delphix Engines (on variants that ship to customers), but only on the build environments where we do builds with linux-pkg and/or appliance-build. |
OK. I'm not clear on the distinctions for builds and runtime requirements. grub-efi-amd64-bin, systemd-boot, and efibootmgr should be installed at runtime. efitools is used to work with EFI and Secure Boot variables so it should be needed at runtime. dosfstools provides the mkfs.fat which we need at image creation though probably not strictly at runtime since I believe we can mount fat fs without |
jfagetti-delphix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding the systemd-boot and EFI related packages necessary for creating an EFI boot image.Background
PR delphix/appliance-build#792 is the follow on change which will generate EFI boot image.
Making sure current BIOS image build is still functional and EFI build would also work.Testing Done
delphix-platform build - https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/os-upgrade/job/build-package/job/delphix-platform/job/pre-push/
combine-packages - https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/os-upgrade/job/combine-packages/job/pre-push/143/
Then appliance builds with current BIOS and EFI changes to build artifacts. Below are outputs from BIOS and EFI engines.
BIOS boot image
EFI boot image