Skip to content

DLPX-73610 pin unzip package to version 6.0-21ubuntu1#132

Merged
pzakha merged 1 commit intodelphix:masterfrom
pzakha:dlpx-73610
Jan 11, 2021
Merged

DLPX-73610 pin unzip package to version 6.0-21ubuntu1#132
pzakha merged 1 commit intodelphix:masterfrom
pzakha:dlpx-73610

Conversation

@pzakha
Copy link
Copy Markdown
Contributor

@pzakha pzakha commented Jan 7, 2021

Comment thread packages/unzip-prebuilt/config.sh Outdated
@prakashsurya
Copy link
Copy Markdown
Contributor

Out of curiosity, if we're pulling in a prebuilt package from artifactory, what is the benefit of doing this in linux-pkg, vs. doing this in appliance-build? e.g. perhaps in the "build-ancillary-repository" step?

@pzakha
Copy link
Copy Markdown
Contributor Author

pzakha commented Jan 7, 2021

Out of curiosity, if we're pulling in a prebuilt package from artifactory, what is the benefit of doing this in linux-pkg, vs. doing this in appliance-build? e.g. perhaps in the "build-ancillary-repository" step?

Not much of a benefit to be honest, I think we could very well do it from there. I can take a look at that.

@prakashsurya
Copy link
Copy Markdown
Contributor

I don't mean to imply I'd rather us do this in appliance-build, I'm just trying to fully understand the underlying architecture for the design of our build system.. and why we do what we do, where we do it.

Comment thread packages/misc-debs/config.sh
@pzakha
Copy link
Copy Markdown
Contributor Author

pzakha commented Jan 8, 2021

After having an offline chat with Prakash, I've made a few changes to how we fetch already built debs.

Here's a summary of the changes:

  1. This is adding a new meta linux-pkg package responsible of fetching all the already-built debs we want to use. Having a single meta package will make it easier to add/remove debs from there in the future.
  2. I've added instructions for how and in which cases to add additional debs.
  3. I've added a SHA256 check to fetched packages to make sure that the binaries downloaded are what we expect.

Additional changes:

  • removed the java8 package since it hasn't been used for a long time.
  • moved td-agent-prebuilt package into this new misc-debs package.

links to re-tests:
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg/job/custom/job/build-package/job/custom/3
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg/job/master/job/combine-packages/job/pre-push/175
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4575/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants