Skip to content

TOOL-11187 leverage linux-pkg to build delphix-masking package#139

Merged
prakashsurya merged 1 commit intodelphix:masterfrom
prakashsurya:delphix-masking
Mar 8, 2021
Merged

TOOL-11187 leverage linux-pkg to build delphix-masking package#139
prakashsurya merged 1 commit intodelphix:masterfrom
prakashsurya:delphix-masking

Conversation

@prakashsurya
Copy link
Copy Markdown
Contributor

@prakashsurya prakashsurya commented Feb 25, 2021

No description provided.

@prakashsurya prakashsurya requested a review from pzakha February 25, 2021 21:50
@prakashsurya prakashsurya force-pushed the delphix-masking branch 2 times, most recently from d52975f to 5c055ad Compare February 25, 2021 22:02
pzakha
pzakha reviewed Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks reasonable. I think it would be useful here to identify other repositories that will need to be changed for this move, sync up with the masking team regarding this change, and establish a deployment plan to make sure to minimize disruptions.

Comment thread package-lists/build/main.pkgs Outdated
@prakashsurya prakashsurya force-pushed the delphix-masking branch 2 times, most recently from f210328 to cbea087 Compare March 4, 2021 20:14
pzakha
pzakha approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a deployment plan for how you will deploy this changes along with the devops-gate changes to minimize disruptions?

Comment thread packages/masking/config.sh
@prakashsurya
Copy link
Copy Markdown
Contributor Author

prakashsurya commented Mar 5, 2021

Do you have a deployment plan for how you will deploy this changes along with the devops-gate changes to minimize disruptions?

My plans are to: 1. land this change, 2. build the masking package via linux-pkg, then 3. push the related devops-gate changes and add this package to main.pkgs.

@prakashsurya prakashsurya force-pushed the delphix-masking branch 3 times, most recently from b442940 to 7a4ac00 Compare March 5, 2021 19:59
@prakashsurya prakashsurya mentioned this pull request Mar 8, 2021
Merged
pcd1193182
pcd1193182 approved these changes Mar 8, 2021
View reviewed changes
Comment thread packages/masking/config.sh Outdated
@prakashsurya prakashsurya merged commit c0f287d into delphix:master Mar 8, 2021
prakashsurya pushed a commit to prakashsurya/linux-pkg that referenced this pull request Mar 23, 2021
TOOL-11187 leverage linux-pkg to build delphix-masking package (delph…
ed46af7 
…ix#139)
prakashsurya pushed a commit to prakashsurya/linux-pkg that referenced this pull request Mar 23, 2021
TOOL-11187 leverage linux-pkg to build delphix-masking package (delph…
b3114dc 
…ix#139)
prakashsurya pushed a commit that referenced this pull request Mar 23, 2021
TOOL-11187 leverage linux-pkg to build delphix-masking package (#139) (…
42d16d7 
…#146)
@ghost ghost mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pcd1193182 pcd1193182 pcd1193182 approved these changes

@pzakha pzakha pzakha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prakashsurya @pcd1193182 @pzakha