TOOL-11245 leverage linux-pkg to build delphix-virtualization package (#145)#149
Merged
prakashsurya merged 1 commit intodelphix:6.0/stagefrom Mar 23, 2021
Merged
Conversation
sdimitro
approved these changes
Mar 23, 2021
Contributor
sdimitro
left a comment
sdimitro
left a comment
There was a problem hiding this comment.
Besides one nit and a question, the code LGTM,
I assume you tested this with Jenkins?
Contributor
Author
I haven't specifically on 6.0/stage, since our policy generally has been clean backports don't require re-verification; but I can test this and report back. |
Contributor
Author
skinner-m-c
approved these changes
Mar 23, 2021
prakashsurya
force-pushed
the
virtualization-bp-2
branch
from
dece6f2 to
1e4e45e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-packagesis herebuild-packageis here