Add dependency on "host-jdks" to "virtualization" package#159
Add dependency on "host-jdks" to "virtualization" package#159prakashsurya merged 2 commits intodelphix:masterfrom
Conversation
|
@pzakha @matt-skinner-delphix |
|
LGTM, pending testing |
|
I kicked off build of this change, plus my in-progress host-jdks work (delphix/host-jdks#3), plus @aditya-joshi-delphix 's in-progress app-gate changes.. see here. |
pzakha
left a comment
There was a problem hiding this comment.
LGTM, pending testing.
FYI, I see that the host-jdks package has been built at http://ops.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg/job/master/job/build-package/job/host-jdks/job/post-push/, so this should be safe once testing passes.
|
Regarding testing I meant the appliance-build-orchestrator run that Aditya linked. I've noticed there are several failures in the blackbox testing: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/91379/#showFailuresLink. Not sure if they are related to those changes, has anyone looked into it? |
|
I have not looked at those failures, but this change, in isolation, should not have any impact on the virtualization package or the product, as it's simply adding a build time dependency (that's currently unused), and nothing else. The build you linked to, include the in-progress changes Aditya is working on for the app-gate, but those changes are not relevant for testing this specific PR. As the changes to the app-gate are worked on, we can (and will) verify those changes with |
|
@pzakha @prakashsurya The failures in http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/91379/#showFailuresLink could be due to https://jira.delphix.com/browse/DLPX-72203 (unrelated to any of these host-jdks changes) ..That's the bug linked in blackbox for the failures..however I see core dumps created during the run..Need to look into it a bit more |
Context:
all host-jdks changes together. host-jdks config.sh, virtualization config.sh and main.pkgs
Testing:
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/5240/console