Skip to content

Add dependency on "host-jdks" to "virtualization" package#159

Merged
prakashsurya merged 2 commits intodelphix:masterfrom
aditya-joshi-delphix:PR-3
May 10, 2021
Merged

Add dependency on "host-jdks" to "virtualization" package#159
prakashsurya merged 2 commits intodelphix:masterfrom
aditya-joshi-delphix:PR-3

Conversation

@aditya-joshi-delphix
Copy link
Copy Markdown
Contributor

@aditya-joshi-delphix aditya-joshi-delphix commented May 7, 2021

Context:

all host-jdks changes together. host-jdks config.sh, virtualization config.sh and main.pkgs

Testing:

http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/5240/console

@aditya-joshi-delphix
Copy link
Copy Markdown
Contributor Author

@pzakha @matt-skinner-delphix

@pzakha
Copy link
Copy Markdown
Contributor

pzakha commented May 7, 2021

LGTM, pending testing

@prakashsurya
Copy link
Copy Markdown
Contributor

I kicked off build of this change, plus my in-progress host-jdks work (delphix/host-jdks#3), plus @aditya-joshi-delphix 's in-progress app-gate changes.. see here.

@aditya-joshi-delphix
Copy link
Copy Markdown
Contributor Author

@pzakha

Copy link
Copy Markdown
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending testing.

FYI, I see that the host-jdks package has been built at http://ops.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg/job/master/job/build-package/job/host-jdks/job/post-push/, so this should be safe once testing passes.

@prakashsurya
Copy link
Copy Markdown
Contributor

Here's a build of the virtualization package, with this change in place: link

@pzakha is this the testing you were looking for?

@prakashsurya prakashsurya changed the title PR-3 all host-jdks changes together Add dependency on "host-jdks" to "virtualization" package May 10, 2021
@prakashsurya prakashsurya merged commit 0f6be53 into delphix:master May 10, 2021
@pzakha
Copy link
Copy Markdown
Contributor

pzakha commented May 10, 2021

Regarding testing I meant the appliance-build-orchestrator run that Aditya linked. I've noticed there are several failures in the blackbox testing: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/91379/#showFailuresLink. Not sure if they are related to those changes, has anyone looked into it?

@prakashsurya
Copy link
Copy Markdown
Contributor

I have not looked at those failures, but this change, in isolation, should not have any impact on the virtualization package or the product, as it's simply adding a build time dependency (that's currently unused), and nothing else.

The build you linked to, include the in-progress changes Aditya is working on for the app-gate, but those changes are not relevant for testing this specific PR.

As the changes to the app-gate are worked on, we can (and will) verify those changes with git-ab-pre-push, and land with git-dx-test, as we would any other app-gate change.

@aditya-joshi-delphix
Copy link
Copy Markdown
Contributor Author

aditya-joshi-delphix commented May 10, 2021

@pzakha @prakashsurya The failures in http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/blackbox-self-service/91379/#showFailuresLink could be due to https://jira.delphix.com/browse/DLPX-72203 (unrelated to any of these host-jdks changes) ..That's the bug linked in blackbox for the failures..however I see core dumps created during the run..Need to look into it a bit more

prakashsurya pushed a commit to prakashsurya/linux-pkg that referenced this pull request May 17, 2021
prakashsurya pushed a commit that referenced this pull request May 20, 2021
Co-authored-by: aditya-joshi-delphix <79338993+aditya-joshi-delphix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants