TOOL-11815 linux-pkg: kernel sync-with-upstream logic sometimes fails to find expected tags upstream#178
Merged
pzakha merged 1 commit intodelphix:masterfrom Jul 13, 2021
Merged
Conversation
… to find expected tags upstream
sebroy
approved these changes
Jun 29, 2021
sdimitro
approved these changes
Jul 12, 2021
Contributor
sdimitro
left a comment
There was a problem hiding this comment.
LGTM and I appreciate the writeout+code_comments
pzakha
added a commit
to pzakha/linux-pkg
that referenced
this pull request
Aug 2, 2021
Backports the following changes: - Add comment to explain use of "--allow-downgrades" (delphix#150) - change drgn upstream repo to main (delphix#161) - TOOL-11734 linux-pkg should use install_build_deps_from_control_file whenever possible (delphix#177) - TOOL-11757 linux-pkg: use build dependencies list stored in virtualization package repository (delphix#175) - TOOL-11815 linux-pkg: kernel sync-with-upstream logic sometimes fails to find expected tags upstream (delphix#178) - TOOL-11892 Bulk modify of shebang lines to use /usr/bin/env (delphix#179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical has 2 ways of naming their tags:
For a given kernel version and a given distribution, only one naming scheme is being used. When two distributions (such as 20.04 and 18.04) use the same major kernel version, Canonical first applies the patches to one distribution and then creates a base tag. It then backports those changes to the older distribution, and then creates a longer tag name.
For instance with the example above we can see that the base tag exists on the 20.04 remote:
While on 18.04 there is the longer tag name:
This review also fixes 2 small issues:
Testing
Ran update-upstream to update all kernels on Focal