JAIL-15 Post-push build for containerized masking#199
Merged
johngallagher-dlpx merged 2 commits intodelphix:masterfrom Oct 29, 2021
Merged
JAIL-15 Post-push build for containerized masking#199johngallagher-dlpx merged 2 commits intodelphix:masterfrom
johngallagher-dlpx merged 2 commits intodelphix:masterfrom
Conversation
prakashsurya
approved these changes
Oct 27, 2021
pzakha
approved these changes
Oct 29, 2021
Contributor
pzakha
left a comment
There was a problem hiding this comment.
We do not currently support having multiple appliance packages with the same git-url, however given that this package is not in the appliance that should be fine. With that said we should probably add a comment above DEFAULT_PACKAGE_GIT_URL explaining that so someone else doesn't get inspired by this way of doing things.
This was referenced Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new package for a new flavor of the masking product. Although the output of this job will not be part of the appliance, we are using linux-pkg since linux-pkg provides a number of useful feature for building generic software, like automatically generated Jenkins jobs that will trigger on post-push, the creation of a build environment with the correct build dependencies installed, a simple way to upload output artifacts to S3, etc.
Because this package is not used by the appliance, we do not include it in any of the package lists, so that its build is not triggered by the
build-packagesjob or bygit ab-pre-push.This new artifact could be built as part of the existing
maskingpackage by just adding another task to the Gradle invocation in that package'sconfig.sh. However, since this package will be used independently, it seemed worth it to keep its build independent, even if it means spending a couple minutes compiling the dms-core-gate bits a second time.Testing
linux-pkg build job
Downloaded the zip file built by the job, loaded the images in the zip into k8s, and made sure the masking application started correctly.