DLPX-82803 [Backport of DLPX-81830] Upgrade Engine JDK to 8u345-b01#245
Merged
smeda-delphix merged 1 commit into6.0/stagefrom Aug 31, 2022
Conversation
smeda-delphix
requested review from
derek-woodham-delphix,
ljiang-delphix,
prakashsurya and
rasantel
prakashsurya
approved these changes
Aug 30, 2022
Contributor
prakashsurya
left a comment
prakashsurya
left a comment
There was a problem hiding this comment.
Since you're making the two branches do the same thing, do we want to remove the conditional?
I'm OK leaving it, if we think we'll diverge again the next time we update the JDK.. and thus, we'd just add the conditional back.. but I wanted to ask..
Contributor
Author
|
Yes, I would prefer leaving it for next time we update JDK. |
rasantel
approved these changes
Aug 30, 2022
derek-woodham-delphix
approved these changes
Aug 30, 2022
smeda-delphix
deleted the
dlpx/pr/smeda-delphix/0d88207d-d145-478b-8d5f-ede7fb4b7310
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade engine JDK to latest version available for 6.0.17.0. A newer version of JDK was released to fix a compiler bug after changes were done in master. So, updating the latest version to master as well.
ab-pre-push - http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/3050/