TOOL-15610 Add flag to buildpkg to cause the build to use locally-built dependencies (fix build breakage)#254
Merged
pcd1193182 merged 1 commit intodelphix:6.0/stagefrom Sep 22, 2022
Conversation
pcd1193182
force-pushed
the
fix_whitespace
branch
from
561632a to
81f043a
Compare
…lt dependencies (fix build breakage)
pcd1193182
force-pushed
the
fix_whitespace
branch
from
81f043a to
70bc858
Compare
Contributor
prakashsurya
approved these changes
Sep 22, 2022
Contributor
the |
Contributor
sumedhbala-delphix
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is is a follow-on to the previous review that fixes a build breakage caused by this change. Because there is whitespace between the two halves of the string assignment, the second half is instead treated as a command to execute. This causes the build to fail. The change contained herein works to fix the issue, but I suspect it will cause the style checker to complain. Is there a more stylistic way to implement this?