TOOL-21507 linux-pkg should fetch releases from new release dataset paths #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palash-gandhi
force-pushed
the
dlpx/pr/pgandhi-delphix/6ab611a3-a087-4d22-8178-ce15a7ee4e1b
branch
from
31a9cf7 to
e1b7633
Compare
prakashsurya
reviewed
Jun 6, 2023
palash-gandhi
force-pushed
the
dlpx/pr/pgandhi-delphix/6ab611a3-a087-4d22-8178-ce15a7ee4e1b
branch
from
e1b7633 to
ef79bb8
Compare
palash-gandhi
force-pushed
the
dlpx/pr/pgandhi-delphix/6ab611a3-a087-4d22-8178-ce15a7ee4e1b
branch
from
ef79bb8 to
88aaa02
Compare
grodr
approved these changes
Jun 7, 2023
prakashsurya
reviewed
Jun 7, 2023
prakashsurya
approved these changes
Jun 7, 2023
Contributor
prakashsurya
left a comment
prakashsurya
left a comment
There was a problem hiding this comment.
I'm OK with this as-is.
prakashsurya
approved these changes
Jun 7, 2023
Contributor
prakashsurya
left a comment
prakashsurya
left a comment
There was a problem hiding this comment.
I'm OK with this as-is.
palash-gandhi
deleted the
dlpx/pr/pgandhi-delphix/6ab611a3-a087-4d22-8178-ce15a7ee4e1b
branch
manoj-joseph
pushed a commit
that referenced
this pull request
Jun 14, 2023
shubhGoel89
pushed a commit
that referenced
this pull request
Jun 30, 2023
jleser
pushed a commit
that referenced
this pull request
Aug 14, 2023
bhavinee-jadav
pushed a commit
that referenced
this pull request
Aug 22, 2023
ncburnett
pushed a commit
that referenced
this pull request
Aug 23, 2023
jleser
pushed a commit
that referenced
this pull request
Aug 23, 2023
mmaybee
pushed a commit
that referenced
this pull request
Sep 7, 2023
sourabh2079
pushed a commit
that referenced
this pull request
Sep 11, 2023
sandeep-delphix
pushed a commit
that referenced
this pull request
Sep 11, 2023
harsha-yellamelli
pushed a commit
that referenced
this pull request
Sep 25, 2023
pcd1193182
pushed a commit
that referenced
this pull request
Oct 4, 2023
lisab-delphix
pushed a commit
that referenced
this pull request
Oct 18, 2023
simonlin-delphix
pushed a commit
that referenced
this pull request
Apr 3, 2024
delphix-aman
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The pregitflow project changed the dataset paths of shipped releases from
http://linux-package-mirror.delphix.com/release/ to http://linux-package-mirror.delphix.com/releases/.
This caused a regression because the linux-pkg repo used the
DEFAULT_GIT_BRANCHas the path of the dataset to fetch from because they were both the samerelease/A.B.C.Dbut now they have changed. The "branches" (tags, really) are still following the old schemerelease/A.B.C.Dbut the datasets are not underreleases/A.B.C.D.So, I modified the jenkins job in https://github.com/delphix/devops-gate/pull/802 to pass the new scheme to linux-pkg,
and it worked for most build-pkg jobs of shipped releases until now when I tried to ship a hotfix of the azure kernel package: http://selfservice.jenkins.delphix.com/job/linux-pkg/job/custom/job/build-package/job/custom/221/console
The reason why this has likely only come to light right now is because the
virtualizationpackage does not have dependencies that needed to be rebuilt.vs in my case:
Solution
The fix should be to revert the jenkins job to continue using the true branch scheme
release/A.B.C.Dinstead ofreleases/A.B.C.Dand modify linux-pkg to not conflate the value to fetch packages from the mirror.Devops-gate review: https://github.com/delphix/devops-gate/pull/1271
Testing Done
http://selfservice.jenkins-palashgandhi.dcol2.delphix.com/job/hotfix-build/14/console
Build a virtualization HF: http://selfservice.jenkins-palashgandhi.dcol2.delphix.com/job/hotfix-build/16/console