Change Login styling #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ram2091999
commented
Feb 2, 2020
ram2091999
commented
- Change the styling of the Login route - /login.
- Style inspired from https://expo.io/login
kumaran-14
requested changes
Feb 4, 2020
| <div className={classnames(styles.root)}> | ||
| <div className={classnames(styles.welcomeBack)}> | ||
| <h1> Welcome back! </h1> | ||
| <p> Log in to access your dashboard, settings, published projects and Snacks. </p> |
Collaborator
There was a problem hiding this comment.
Welcome ! is fine.
Login to access dashboard and profile
Collaborator
|
The error message can be displayed like this. |
Collaborator
|
kumaran-14
requested changes
Feb 5, 2020
Comment on lines
66
to
70
| className="text-center text-dark mb-2" | ||
| style={{ | ||
| fontFamily: 'Poppins', | ||
| fontSize: '12px', | ||
| marginTop: '0', |
Collaborator
There was a problem hiding this comment.
styles should go in module file.
Comment on lines
175
to
176
| color: '#4630eb', | ||
| cursor: 'pointer', |
Collaborator
There was a problem hiding this comment.
Should go in css modules.
kumaran-14
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.