Disallow double quotes in email address, remove repeated trailing '.' from email address #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at end of email address
jackaperkins
force-pushed
the
greedy-email
branch
from
551ccab to
1914b28
Compare
Collaborator
|
Sorry for the delay, Jack. |
farooqkz
approved these changes
May 19, 2025
Collaborator
farooqkz
left a comment
farooqkz
left a comment
There was a problem hiding this comment.
Solves the problem. But email parsing logic is definitely not good. But it's not something Jack is supposed to do. We need a refactor/rewrite of email parsing. For now, I would say to have this quick fix and later think about the rewrite/refactor.
Collaborator
|
@Simon-Laux If you approve, you can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #78