Add proper issue template for bug reports #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
reviewed
Mar 30, 2025
Simon-Laux
reviewed
Mar 30, 2025
Simon-Laux
reviewed
Mar 30, 2025
Simon-Laux
requested changes
Mar 30, 2025
Member
Simon-Laux
left a comment
Simon-Laux
left a comment
There was a problem hiding this comment.
I think the most important are the test cases, it should explain how to get them:
https://deltachat.github.io/message-parser/
Test case should be ideally input, expected output AST and actual output AST.
Simon-Laux
reviewed
Apr 8, 2025
Simon-Laux
reviewed
Apr 8, 2025
Simon-Laux
reviewed
Apr 8, 2025
Simon-Laux
reviewed
Apr 8, 2025
Member
we could change the demo site, like add a copy button to the field where the AST is displayed. |
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
Member
|
Anyways I'm not really sure that we need an issue template. I'm glad if people report bugs, they might not if we increase the barrier of entry / time cost of filing bugs. |
Member
|
not worth the effort for now, we can consider increasing friction, when we get too many bug reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How do we test it without merging? Also, is it possible to provide a better interface for test cases?