Skip to content

Conversation

@kiivihal
Copy link
Member

@kiivihal kiivihal commented Oct 5, 2020

The posthook-lifecycle is now more generically available. In the
configuration you can now add a customWait, user/password for
basic-auth.

The posthook-lifecycle is now more generically available. In the
configuration you can now add a customWait, user/password for
basic-auth.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@kiivihal kiivihal marked this pull request as draft October 5, 2020 12:14
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.08%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   32.19%   32.10%   -0.09%     
==========================================
  Files         115      115              
  Lines       13418    13461      +43     
==========================================
+ Hits         4320     4322       +2     
- Misses       8828     8869      +41     
  Partials      270      270              
Flag Coverage Δ
#unittests 32.10% <7.69%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/config.go 66.07% <ø> (ø)
hub3/index/elasticsearch.go 0.00% <ø> (ø)
hub3/server/http/handlers/datasets.go 0.00% <0.00%> (ø)
hub3/server/http/handlers/introspection.go 0.00% <0.00%> (ø)
ikuzo/service/x/index/option.go 23.52% <0.00%> (-5.05%) ⬇️
ikuzo/storage/x/ginger/posthook.go 0.00% <0.00%> (ø)
ikuzo/service/x/index/service.go 15.17% <3.70%> (-2.48%) ⬇️
ikuzo/service/x/ead/service.go 14.28% <30.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bebf7e...10fd1ae. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@kiivihal kiivihal marked this pull request as ready for review October 17, 2020 09:52
@kiivihal kiivihal requested a review from glamcloud October 17, 2020 09:52
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@glamcloud glamcloud merged commit fb65818 into master Oct 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
@kiivihal kiivihal deleted the feature/posthook-lifecycle-hooks branch October 22, 2020 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants