Skip to content

Conversation

@warmwaterkruik
Copy link
Contributor

@warmwaterkruik warmwaterkruik commented Nov 13, 2020

  1. The struct FragmentGraph needs the json protobuf marshalling directive so Elasticsearch stores these protobuf message or else the /api/pb/viewer/list will fail
  2. The resource.NewFields has a fieldMap map that has unsorted sub maps. But we need to preserve the order of the resource entries in fg.Fields.

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #63 (d67249d) into master (8ba6a0a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   31.97%   31.94%   -0.04%     
==========================================
  Files         115      115              
  Lines       13629    13642      +13     
==========================================
  Hits         4358     4358              
- Misses       8998     9011      +13     
  Partials      273      273              
Flag Coverage Δ
unittests 31.94% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub3/ead/mets.go 28.95% <ø> (ø)
hub3/fragments/resource.go 25.83% <0.00%> (-0.22%) ⬇️
hub3/server/http/handlers/search.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba6a0a...d67249d. Read the comment docs.

@kiivihal
Copy link
Member

Can you update the changelog as well?

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kiivihal kiivihal merged commit 72e9e60 into master Nov 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2020
@warmwaterkruik warmwaterkruik deleted the feature/sort-fields-store-proto branch November 17, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants