Feature/v1 indexing fixes #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Graph().All() functions seems to randomly miss certain triples when iterating. When using IterTriples directly this bug does not manifest.
Contributor
|
CLA Assistant Lite All Contributors have signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 31.94% 31.94% -0.01%
==========================================
Files 115 115
Lines 13642 13649 +7
==========================================
+ Hits 4358 4360 +2
- Misses 9011 9015 +4
- Partials 273 274 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
warmwaterkruik
previously approved these changes
Dec 5, 2020
Contributor
warmwaterkruik
left a comment
warmwaterkruik
left a comment
There was a problem hiding this comment.
Looks good. Robot tests are clean as well.
Contributor
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request contains some fixes to the v1 bulk indexing API.
when indexing via the bulk index API the recordType is also included for indexing. 'mdr' and 'narthex_record' are supported as the defaults when received from Nathex
due to a bug in the external RDF library when using rdf2go.Graph().All() does not return all the matching triples. This working around using rd2go.Graph().IterTriples() makes sure that resolving the RDF labels returns all the labels.