Skip to content

Conversation

@slundqui
Copy link

@slundqui slundqui commented Aug 29, 2024

Event decoder in agent0 wasn't working for nested event types. This PR allows the event decoder to properly decode nested types to look for topic hashes.

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (f203fa1) to head (0fd26b5).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   82.39%   82.36%   -0.04%     
==========================================
  Files          98       98              
  Lines        7486     7495       +9     
==========================================
+ Hits         6168     6173       +5     
- Misses       1318     1322       +4     
Flag Coverage Δ
unittests 82.36% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wakamex wakamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you can ignore these nits if you want, they're really minor

@slundqui slundqui merged commit fc34f95 into delvtech:main Aug 29, 2024
@slundqui slundqui deleted the fix-event-decoder branch August 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants