Skip to content

trade history applied marginally and simplified#576

Merged
wakamex merged 28 commits intomainfrom
wakamex/dump_state
Jul 3, 2023
Merged

trade history applied marginally and simplified#576
wakamex merged 28 commits intomainfrom
wakamex/dump_state

Conversation

@wakamex
Copy link
Copy Markdown
Contributor

@wakamex wakamex commented Jun 22, 2023

trade history simplified to 1 dataframe (trade_history)
trade_history updates only marginally (missing blocks) which is faster

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 10:59pm

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 5.26% and project coverage change: +0.15 🎉

Comparison is base (92235e8) 71.85% compared to head (8865b17) 72.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   71.85%   72.01%   +0.15%     
==========================================
  Files          54       54              
  Lines        2903     2912       +9     
==========================================
+ Hits         2086     2097      +11     
+ Misses        817      815       -2     
Flag Coverage Δ
unittests 72.01% <5.26%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
elfpy/utils/apeworx_integrations.py 23.87% <5.26%> (-0.62%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread elfpy/utils/apeworx_integrations.py Outdated
Comment thread elfpy/utils/apeworx_integrations.py Outdated
Comment thread elfpy/utils/apeworx_integrations.py
Comment thread examples/evm_bots.py Outdated
Comment thread elfpy/utils/apeworx_integrations.py Outdated
Comment thread examples/evm_bots.py Outdated
@dpaiton
Copy link
Copy Markdown
Contributor

dpaiton commented Jul 1, 2023

Can you move the two tests into their own subfolder?

@wakamex
Copy link
Copy Markdown
Contributor Author

wakamex commented Jul 3, 2023

Can you move the two tests into their own subfolder?

they'd be the only file in its own subfolder, are you sure?

  • test_solidity has 10 files
  • pricing_models has 6 files
  • cross_platform has 11 files
  • base tests folder has 10 files included test_dumps.py

PS: oh I guess you mean test_transformers.py as well? I thought you meant a state_dumps folder or something. I didn't work on that file, just updated it so it doesn't crash.

PPS: agreed offline

@wakamex wakamex changed the title crash processing and recovery trade history applied marginally and simplified Jul 3, 2023
@wakamex wakamex merged commit 9f7c366 into main Jul 3, 2023
@wakamex wakamex deleted the wakamex/dump_state branch July 3, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants