Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 19 commits
July 3, 2023 18:12
…ts results as fixedpoint
slundqui
force-pushed
the
postgres_updates
branch
from
411c83d to
4ceb668
Compare
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
reviewed
Jul 4, 2023
dpaiton
approved these changes
Jul 4, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
Left some comments, but otherwise it looks great. Did you try syncing this up with the full demo pipeline (devnet -> bot trades -> postgres -> streamlit)? I think that would be a good test to do before merging.
Author
This was tested with the demo pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks acquire_data.py to read/write to/from postgres instead of from file.