Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wakamex
force-pushed
the
wakamex/improve_pnl_calc
branch
from
602d6d4 to
16e4a68
Compare
dpaiton
reviewed
Jul 6, 2023
dpaiton
reviewed
Jul 6, 2023
Contributor
There was a problem hiding this comment.
Can you add a top level docstring explaining the get_wallet_from_trade_history function logic in more detail? I'm having trouble following what is going on from the in-line comments & code. This will also make it easier to maintain functionality when we switch to web3.
wakamex
force-pushed
the
wakamex/improve_pnl_calc
branch
from
16e4a68 to
e9cb121
Compare
wakamex
force-pushed
the
wakamex/improve_pnl_calc
branch
from
e570636 to
110363c
Compare
dpaiton
reviewed
Jul 6, 2023
dpaiton
approved these changes
Jul 6, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
thanks for getting this done!
wakamex
force-pushed
the
wakamex/improve_pnl_calc
branch
from
ca95702 to
ab2ca7a
Compare
|
Remaining rate limit: 4940 🚀 |
|
Remaining rate limit: 4930 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate marginal and full updates of open share price
remove empty positions from wallet