Add calculate_max_long and calculate_max_short#675
Merged
sentilesdal merged 12 commits intomainfrom Jul 17, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sentilesdal
changed the title
|
Remaining rate limit: 4993 🚀 |
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
|
Remaining rate limit: 4987 🚀 |
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
3270f0c to
73f26c0
Compare
|
Remaining rate limit: 5000 🚀 |
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
73f26c0 to
1d1f3f5
Compare
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
1d1f3f5 to
a36469d
Compare
|
Remaining rate limit: 4999 🚀 |
|
Remaining rate limit: 4991 🚀 |
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
c197a35 to
6fe0cc4
Compare
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
6fe0cc4 to
916078a
Compare
sentilesdal
force-pushed
the
matt-max-long-and-short
branch
from
916078a to
0341920
Compare
|
Remaining rate limit: 4991 🚀 |
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
reviewed
Jul 17, 2023
dpaiton
suggested changes
Jul 17, 2023
Contributor
There was a problem hiding this comment.
EDIT: Matt says he will do this in a follow-up PR
Can you integrate these changes into elfpy by calling the appropriate functions in
and
get_max_short: https://github.com/delvtech/elf-simulations/blob/matt-max-long-and-short/elfpy/markets/hyperdrive/hyperdrive_pricing_model.py#L80
dpaiton
approved these changes
Jul 17, 2023
|
Remaining rate limit: 4959 🚀 |
|
Remaining rate limit: 4953 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds news methods for calculate_max_long and calculate_max_short. Also included are the functions that these need for the calculation, including calculate_max_buy and calculate_spot_price. There is some overlap with our existing functions but I wanted to have a copy that was a transliteration of the solidity code so that we can compare if anything changes or breaks. There is some cleanup to do here still but this is ready for some eyes.