Skip to content

fix requires-python#678

Merged
wakamex merged 3 commits intomainfrom
fix_requires_python
Jul 18, 2023
Merged

fix requires-python#678
wakamex merged 3 commits intomainfrom
fix_requires_python

Conversation

@wakamex
Copy link
Copy Markdown
Contributor

@wakamex wakamex commented Jul 18, 2023

according to python.org have to match version specifiers most recently defined by PEP 440
examples:

~=3.1: version 3.1 or later, but not version 4.0 or later.
~=3.1.2: version 3.1.2 or later, but not version 3.2.0 or later.
~=3.1a1: version 3.1a1 or later, but not version 4.0 or later.
== 3.1: specifically version 3.1 (or 3.1.0), excludes all pre-releases, post releases, developmental releases and any 3.1.x maintenance releases.
== 3.1.*: any version that starts with 3.1. Equivalent to the ~=3.1.0 compatible release clause.
~=3.1.0, != 3.1.3: version 3.1.0 or later, but not version 3.1.3 and not version 3.2.0 or later.

I was alerted to this by ruff which was correctly throwing an error:

error: TOML parse error at line 20, column 19
   |
20 | requires-python = "3.10"
   |                   ^^^^^^
Failed to parse version:
3.10
^^^^

PS: also noticed pip would throw a warning:

pip install -e .
Obtaining file:///code/elfpy
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
WARNING: Package 'elfpy' has an invalid Requires-Python: Invalid specifier: '3.10'

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 6:54pm

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4993 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4960 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4941 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4993 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4975 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4927 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4924 🚀

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4916 🚀

Copy link
Copy Markdown
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@github-actions
Copy link
Copy Markdown

Remaining rate limit: 4972 🚀

@wakamex wakamex merged commit 49f2850 into main Jul 18, 2023
@wakamex wakamex deleted the fix_requires_python branch July 18, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants