Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Remaining rate limit: 4988 🚀 |
|
Remaining rate limit: 4983 🚀 |
sentilesdal
approved these changes
Jul 20, 2023
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
let's remove that NaN coercion. would rather see negative values and then debug. calculate_spot_price is just a pure math function, the responsibility to ensure proper values lies upstream
wakamex
force-pushed
the
add_safety_check_for_calc_spot_price_in_hyperdrive_pricing_model
branch
from
2b56d29 to
bcbeee6
Compare
|
Remaining rate limit: 4981 🚀 |
|
Remaining rate limit: 4945 🚀 |
|
Remaining rate limit: 4932 🚀 |
|
Remaining rate limit: 4994 🚀 |
|
Remaining rate limit: 4995 🚀 |
|
Remaining rate limit: 4908 🚀 |
|
Remaining rate limit: 4893 🚀 |
|
Remaining rate limit: 4893 🚀 |
|
Remaining rate limit: 4999 🚀 |
|
Remaining rate limit: 4994 🚀 |
|
Remaining rate limit: 4979 🚀 |
|
Remaining rate limit: 4972 🚀 |
|
Remaining rate limit: 4960 🚀 |
wakamex
changed the title
Contributor
Author
wakamex
deleted the
add_safety_check_for_calc_spot_price_in_hyperdrive_pricing_model
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.