Skip to content

more pythonic logs with per-handler log levels#735

Merged
wakamex merged 4 commits intomainfrom
more_pythonic_logging_separate_log_levels
Jul 26, 2023
Merged

more pythonic logs with per-handler log levels#735
wakamex merged 4 commits intomainfrom
more_pythonic_logging_separate_log_levels

Conversation

@wakamex
Copy link
Copy Markdown
Contributor

@wakamex wakamex commented Jul 24, 2023 •
edited
Loading

  • set log level at the handler level, to allow separate levels
  • clarify setup_logging should only be called once, at initialization
  • for custom logging, use add_stdout_handller and add_file_handler
  • sane defaults in eth_bots reduces spam from libraries:
    • urllib3 logging set to WARNING
    • web3 logging set to WARNING
    • filter web3 warnings about base_contract MismatchedABI(The event signature did not match the provided ABI). It has been discarded.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:42pm

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 24, 2023

Remaining rate limit: 4981 🚀

@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from 92ca303 to c6dd093 Compare July 26, 2023 16:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4972 🚀

dpaiton
dpaiton reviewed Jul 26, 2023
View reviewed changes
Comment thread elfpy/utils/logs.py
@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from c6dd093 to aa67c46 Compare July 26, 2023 19:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4978 🚀

wakamex
wakamex commented Jul 26, 2023
View reviewed changes
Comment thread elfpy/utils/logs.py
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4970 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4958 🚀

@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from e5808f1 to b6d39ed Compare July 26, 2023 19:32
@wakamex wakamex changed the title more pythonic logs with separate log levels per handler more pythonic logs with per-handler log levels Jul 26, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4936 🚀

@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from b6d39ed to 75c2f1c Compare July 26, 2023 19:41
@wakamex wakamex marked this pull request as draft July 26, 2023 19:41
@wakamex wakamex marked this pull request as ready for review July 26, 2023 19:42
@wakamex wakamex requested a review from dpaiton July 26, 2023 19:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4919 🚀

@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from 75c2f1c to f37ef77 Compare July 26, 2023 19:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4991 🚀

dpaiton
dpaiton reviewed Jul 26, 2023
View reviewed changes
Comment thread elfpy/utils/logs.py Outdated
dpaiton
dpaiton reviewed Jul 26, 2023
View reviewed changes
Comment thread elfpy/utils/logs.py Outdated
dpaiton
dpaiton reviewed Jul 26, 2023
View reviewed changes
Comment thread elfpy/utils/logs.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4954 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4923 🚀

@wakamex wakamex force-pushed the more_pythonic_logging_separate_log_levels branch from 9a20bc2 to 9640de0 Compare July 26, 2023 20:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2023

Remaining rate limit: 4999 🚀

@wakamex wakamex merged commit cdd655c into main Jul 26, 2023
@wakamex wakamex deleted the more_pythonic_logging_separate_log_levels branch July 26, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dpaiton dpaiton dpaiton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wakamex @dpaiton