Using wallet deltas from transaction logs#772
Merged
slundqui merged 12 commits intodelvtech:mainfrom Aug 1, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Remaining rate limit: 5000 🚀 |
|
Remaining rate limit: 4997 🚀 |
wakamex
reviewed
Aug 1, 2023
wakamex
reviewed
Aug 1, 2023
wakamex
reviewed
Aug 1, 2023
wakamex
reviewed
Aug 1, 2023
wakamex
reviewed
Aug 1, 2023
wakamex
approved these changes
Aug 1, 2023
sentilesdal
suggested changes
Aug 1, 2023
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
changes requested plz
Contributor
|
did you just SAY changes requested? |
|
Remaining rate limit: 4994 🚀 |
Contributor
|
do you think we'll ever find out what changes matthew requested? he's such a picky guy |
sentilesdal
approved these changes
Aug 1, 2023
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
approved with dylan's review
slundqui
force-pushed
the
transactions_ticker
branch
from
3e8a8bb to
f9d11be
Compare
|
Remaining rate limit: 4999 🚀 |
|
Remaining rate limit: 4992 🚀 |
sentilesdal
reviewed
Aug 1, 2023
sentilesdal
reviewed
Aug 1, 2023
sentilesdal
reviewed
Aug 1, 2023
|
Remaining rate limit: 4996 🚀 |
sentilesdal
reviewed
Aug 1, 2023
dpaiton
approved these changes
Aug 1, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
Looks good! Approved pending rewrite of the WalletDeltas db
|
Remaining rate limit: 4996 🚀 |
added 12 commits
August 1, 2023 14:03
slundqui
force-pushed
the
transactions_ticker
branch
from
8829388 to
e511434
Compare
|
Remaining rate limit: 4996 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts position deltas from transaction logs. These deltas get fed into postgres, and the dashboard now uses these deltas for pnl calculations. This PR also adds these wallet deltas to the dashboard ticker.