Skip to content

calculate pnl for closeout#788

Merged
wakamex merged 9 commits intomainfrom
closeout_pnl
Aug 4, 2023
Merged

calculate pnl for closeout#788
wakamex merged 9 commits intomainfrom
closeout_pnl

Conversation

@wakamex
Copy link
Copy Markdown
Contributor

@wakamex wakamex commented Aug 4, 2023 •
edited
Loading

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 11:30pm

@wakamex
Copy link
Copy Markdown
Contributor Author

wakamex commented Aug 4, 2023

@sentilesdal I changed your smart_contract_preview_transaction to take an address as an input instead of an EthAgent, so I can call it when I don't have an EthAgent, but I do have an address. Changed where it's called to extract the address from EthAgent prior to calling it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4994 🚀

@wakamex
Copy link
Copy Markdown
Contributor Author

wakamex commented Aug 4, 2023

@slundqui I used coerce_float=False in the postgres queries. Since that test is a success, should we just maket that the default?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4990 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4984 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4975 🚀

@wakamex wakamex changed the title calculate pnl for closeout calculate pnl for closeout (includes PR #789) Aug 4, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4988 🚀

@wakamex wakamex changed the title calculate pnl for closeout (includes PR #789) calculate pnl for closeout Aug 4, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4971 🚀

@slundqui
Copy link
Copy Markdown

slundqui commented Aug 4, 2023

@slundqui I used coerce_float=False in the postgres queries. Since that test is a success, should we just maket that the default?

No, I think in general, anything consuming from the database for the purposes of dashboarding should be able to handle the faster but less accurate floats instead of the more accurate but slower decimal format

slundqui
slundqui approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown

@slundqui slundqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

Comment thread src/dashboard/calc_pnl.py Outdated
Comment thread src/dashboard/calc_pnl.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4988 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4994 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4968 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4965 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4963 🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

Remaining rate limit: 4960 🚀

@wakamex wakamex merged commit 329ef81 into main Aug 4, 2023
@wakamex wakamex deleted the closeout_pnl branch August 4, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@slundqui slundqui slundqui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wakamex @slundqui