Skip to content

Using local postgres for pytest#843

Merged
slundqui merged 16 commits intodelvtech:mainfrom
slundqui:postgres_tests
Aug 21, 2023
Merged

Using local postgres for pytest#843
slundqui merged 16 commits intodelvtech:mainfrom
slundqui:postgres_tests

Conversation

@slundqui
Copy link
Copy Markdown

@slundqui slundqui commented Aug 21, 2023 •
edited
Loading

  1. Spinning local postgres container for testing (system-test: Use postgres in tests instead of sqlite #836)
  2. Using conftest for test fixtures to avoid importing fixture dependencies in tests
  3. Fixing rounding bugs with fixedpoint (Fixed point should not accept floating point in constructor fixedpointmath#21)

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 10:44pm

@slundqui slundqui marked this pull request as ready for review August 21, 2023 21:01
sentilesdal
sentilesdal approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only smol things

Comment thread conftest.py
Comment thread lib/chainsync/chainsync/test_fixtures/db_session.py
Comment thread lib/chainsync/chainsync/test_fixtures/db_session.py Outdated
Comment thread lib/chainsync/chainsync/db/hyperdrive/schema.py
Comment thread tests/system_test.py Outdated
Comment thread README.md
Comment thread conftest.py
dpaiton
dpaiton reviewed Aug 21, 2023
View reviewed changes
Comment thread tests/system_test.py
dpaiton
dpaiton approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would prefer if we added e.g. Decimal(FixedPoint("5.2")) support instead of the helper function.

@slundqui slundqui merged commit e4d4b57 into delvtech:main Aug 21, 2023
@slundqui slundqui deleted the postgres_tests branch August 21, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dpaiton dpaiton dpaiton approved these changes

@sentilesdal sentilesdal sentilesdal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slundqui @dpaiton @sentilesdal