Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b76582c to
ff79f65
Compare
b136cc0 to
0dbe7a5
Compare
0dbe7a5 to
88b13b1
Compare
88b13b1 to
0eec55a
Compare
8a73761 to
5f3390f
Compare
|
I think there's a way to run whatever python code you need when you do pip install. Right now, we're using pyproject.toml, which handles that for you, but I think a replacement using setup.py allows you to run arbitrary python code during a pip install. Hence, you can imagine doing pip install pypechain (or having it in requirements.txt) run the codegen stuff. Unfortuantly, there's still the issue of pointing it to the abis |
This is a good option. We should consider 1) that will require modifying our install process everywhere else to be consistent. 2) this is the older method, and the PEPs linked in the PR explain why it's generally better to move to the new pyproject.toml system. 3) it's not clear that this is safer or more transparent or better in any way than a makefile or install.sh file Pointing it to the ABIs should be fine since we're standardizing where they live ( edit: I guess we could have pypechain use |
|
@sentilesdal has suggested that we commit the generated code and leave it as a |
a54d66b to
f447853
Compare
|
I like this. You probably could write a test that regenerates the code and ensures the committed versions are correct. |
a4706ca to
cbc9ad2
Compare
cbc9ad2 to
2b1f8d3
Compare
914d667 to
5edb7a7
Compare
This PR adds the `hyperdrive_types` package to `lib`. This package is comprised of a shell script that recursively parses an `abi` folder for ABI JSON files, and calls `pypechain` to generate the corresponding python files. Due to problems described in the discussion below, we opted to also commit the programmatically generated python files to this repo. Original description of the problem is in [this comment below](delvtech/agent0#888 (comment)).
This PR adds the `hyperdrive_types` package to `lib`. This package is comprised of a shell script that recursively parses an `abi` folder for ABI JSON files, and calls `pypechain` to generate the corresponding python files. Due to problems described in the discussion below, we opted to also commit the programmatically generated python files to this repo. Original description of the problem is in [this comment below](delvtech/agent0#888 (comment)).
This PR adds the
hyperdrive_typespackage tolib. This package is comprised of a shell script that recursively parses anabifolder for ABI JSON files, and callspypechainto generate the corresponding python files. Due to problems described in the discussion below, we opted to also commit the programmatically generated python files to this repo.Original description of the problem is in this comment below.