Fix Event Params and conditional imports#898
Merged
sentilesdal merged 5 commits intomainfrom Sep 25, 2023
Merged
Conversation
we weren't including all the params, also fixes conditional imports
ContractFunction is generic, we are passing specific arguments now so we should ignore this warning
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dpaiton
reviewed
Sep 25, 2023
dpaiton
approved these changes
Sep 25, 2023
Contributor
dpaiton
left a comment
dpaiton
left a comment
There was a problem hiding this comment.
thanks for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug where we weren't including all the event params for events. This is fixed. Also, the imports for ABIEvent and ABIEventParams are now conditionally imported.