Skip to content

Crash reporting now takes optional argument for log level #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slundqui merged 2 commits into from
Oct 16, 2023
Merged

Crash reporting now takes optional argument for log level #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987931a
Crash reporting now takes optional argument for log level
Oct 16, 2023
f0a71f0
docstring formatting
Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/agent0/agent0/hyperdrive/crash_report/crash_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,24 @@ def setup_hyperdrive_crash_report_logging(log_format_string: str | None = None)
)


def log_hyperdrive_crash_report(trade_result: TradeResult) -> None:
def log_hyperdrive_crash_report(trade_result: TradeResult, log_level: int | None = None) -> None:
# pylint: disable=too-many-arguments
"""Log a crash report for a hyperdrive transaction.

Arguments
---------
trade_result: TradeResult
The trade result object that stores all crash information
log_level: int | None
The logging level for this crash report. Defaults to critical.

Returns
-------
None
This function does not return any value.
"""
if log_level is None:
log_level = logging.CRITICAL

exception = trade_result.exception
formatted_exception = repr(exception)
Expand All @@ -108,7 +112,8 @@ def log_hyperdrive_crash_report(trade_result: TradeResult) -> None:
assert exception is not None
formatted_traceback = "".join(format_tb(exception.__traceback__))

logging.critical(
logging.log(
log_level,
"""Exception: %s\nTrade: %s\nWallet: %s\nPoolInfo: %s\nPoolConfig: %s\nTraceback: %s\n""",
formatted_exception,
formatted_trade_obj,
Expand Down
8 changes: 5 additions & 3 deletions lib/agent0/agent0/hyperdrive/exec/trade_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ def trade_if_new_block(
assert trade_result.pool_info is not None

# Crash reporting
# TODO add optional argument to crash reporting for logging level
# https://github.com/delvtech/elf-simulations/issues/967
log_hyperdrive_crash_report(trade_result)
if is_slippage:
log_hyperdrive_crash_report(trade_result, logging.WARNING)
else:
# Defaults to CRITICAL
log_hyperdrive_crash_report(trade_result)

if halt_on_errors:
# Don't halt if slippage detected and halt_on_slippage is false
Expand Down