This repository was archived by the owner on May 2, 2024. It is now read-only.
Conversation
dpaiton
force-pushed
the
dpaiton/add_utils
branch
from
18a273b to
d82c800
Compare
This was referenced Oct 19, 2023
dpaiton
force-pushed
the
dpaiton/add_utils
branch
2 times, most recently
from
14f9d9d to
7d8dba2
Compare
dpaiton
force-pushed
the
dpaiton/add_utils
branch
from
7d8dba2 to
2225d20
Compare
sentilesdal
approved these changes
Oct 24, 2023
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
looks good to me. wary of saying 'fixedpoint' because someone might be tempted to pass '1.23' instead of '123000000000000000'
dpaiton
force-pushed
the
dpaiton/add_utils
branch
from
605fde3 to
7e43cce
Compare
dpaiton
force-pushed
the
dpaiton/add_utils
branch
from
7e43cce to
69a4aee
Compare
Contributor
Author
I decided to leave it because it references the underlying Rust type. However, I think this is a good point and we should include an explanation in the readme when we go live. (or ignore if we end up using FixedPoint everywhere anyway) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.