Add getShortBondsGivenDeposit to sdk, absDiff to fixed point
#1549
Conversation
🦋 Changeset detectedLatest commit: 574b53f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
| asBase: true, | ||
| }); | ||
|
|
||
| assert(targetDeposit.absDiff(traderDeposit).lte(tolerance)); |
| amountIn: bigint; | ||
| asBase: boolean; | ||
| /** | ||
| * The maximum difference between the target and actual base amount. |
There was a problem hiding this comment.
1e9 is decent for 18 decimal numbers, but for usdc (6 decimals) we'll definitely want to set a smaller tolerance. Should we capture this in the TokenConfig, HyperdriveConfig, or just inline a bit of logic in our hook to look at the token decimals and map that to a known good tolerance?
There was a problem hiding this comment.
We could also just make the default tolerance in ReadHyperdrive dynamic based on hyperdrive.decimals. 🤔
There was a problem hiding this comment.
Good question. I'd confirm with @dpaiton on how far this tolerance can go before it stops working, but if the tolerance a pool uses is data based on other data (e.g., the token's decimals) then I'd inline it to keep the config data more normalized.
DannyDelott
left a comment
DannyDelott
left a comment
There was a problem hiding this comment.
I'm so excited for this! 🚀
Adds bindings for
calculate_short_bonds_given_deposit.Commits tell the story.