Skip to content

Conversation

@DannyDelott
Copy link
Contributor

This PR addresses inconsistencies in our appConfig selectors by standardizing their structure:

  • Unified naming convention: All selectors now use the getFoo prefix, replacing the mixed usage of getFoo and findFoo.
  • Argument consistency: Selectors now accept the entire appConfig object as an argument, eliminating the need for consumers to pass specific slices of appConfig.

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 984e0d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:21pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm
testnet-v1 ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm
trading-competition ⬜️ Ignored (Inspect) Nov 12, 2024 5:21pm

@DannyDelott DannyDelott merged commit 925029d into main Nov 12, 2024
14 checks passed
@DannyDelott DannyDelott deleted the danny-selector-cleanup branch November 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants