Add priceOracle to appconfig, add defillama price oracle, and selector #1651
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
DannyDelott
force-pushed
the
danny-move-fiat-price-into-appconfig
branch
from
c9f9d1c to
8eb26e0
Compare
DannyDelott
force-pushed
the
danny-move-fiat-price-into-appconfig
branch
from
8eb26e0 to
2c27830
Compare
| appConfig, | ||
| }); | ||
| let alreadyExists = false; | ||
| try { |
There was a problem hiding this comment.
I'm not sure I understand why we need the try catch here. Since getToken returns undefined can we just look at the variable to determine if it exists?
const alreadyExists = !!getToken({
chainId: reward.chainId,
tokenAddress: reward.tokenAddress,
appConfig,
});
if (alreadyExists) {
return;
}There was a problem hiding this comment.
getToken will throw an error now if you call it and it doesn't find a token. This is the behavior we want because it's a sign that the appconfig is malformed. In this case, though, since we're calling it before the reward tokens are included, we'll get an error thrown at us.
Related to #1629
This PR introduces a new
priceOraclefield to theTokenConfiginterface and defines aPriceOracleFnfunction type. This uses a strategy pattern (similar to what we're doing for rewards), so that it's easy to add new price oracle functions.At the moment, we only need
defillamastrategy, but a TODO has been added to provide auniswapv3oracle function to handle zappable tokens in the near future.