Add dependency-cruiser, fix depcruise violations #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
DannyDelott
force-pushed
the
danny-add-dependency-cruiser
branch
from
623e2ac to
8afbb4d
Compare
DannyDelott
force-pushed
the
danny-add-dependency-cruiser
branch
from
78ecd9c to
7c3c289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been wanting to use this in the monorepo for a while, but dependency-cruiser wasn't playing nicely with Turborepo. It appears that's all been worked out by the library author, so we can start using this tool!
Out the gate, this caught several instances of depending on packages that were not included in the
package.json, depending on devDependencies where we shouldn't be, as well as several orphaned files.We'll be able to add other rules to lock down our own dependency rules too, eg:
src/baseandsrc/ui/baseshould not import from any other feature foldersui/hyperdriveshould not import fromui/portfolio(the other way around is fine)src/uishould import from React or files withinsrc/uiAs our codebase continues to grow, dependency-cruiser will play a vital role in pinning down the way we manage our dependencies and keeping our feature folders clean.