Skip to content

Accept negative APR/APYs in HPR utils#133

Merged
ryangoree merged 1 commit intomainfrom
ryan-type-fix
Jun 10, 2024
Merged

Accept negative APR/APYs in HPR utils#133
ryangoree merged 1 commit intomainfrom
ryan-type-fix

Conversation

@ryangoree
Copy link
Member

Resolved Issues

Fixes #132

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.

  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?
    • If matching Solidity behavior, are there differential fuzz tests that
      ensure that Rust matches Solidity?

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryangoree ryangoree merged commit d8f25dd into main Jun 10, 2024
@ryangoree ryangoree deleted the ryan-type-fix branch June 10, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor calculate_hpr_given_apr to accept I256 for negative rates.

2 participants