The netCurveTrade has units of [bonds] but maxCurveTrade has units of [shares] or [bonds/price]. So the ‘else’ branch where the net curve trade is negative, there seems to be a mixture of units, and the value that is passed to the calculateSharesInGivenBondsOut should be in bonds, not shares.

[jalextowle]

[jalextowle]

This was fixed in #304. The logic was incorrect previously, and we updated this by using a calculation of the maximum amount of bonds that can be purchased before the curve goes into a negative interest region.