[CRASH REPORT] Approval issue for tokens similar to USDT

[MerlinEgalite]

Crash Report

Description

safeApprove from solmate is used here:

hyperdrive/contracts/src/instances/erc4626/ERC4626Base.sol

Line 61 in 73b7616

ERC20(address(_baseToken)).safeApprove(address(_vault), _amount);

There might be an issue if the approval is not reset to 0 at some point for tokens that behave like USDT ie tokens preventing the allowance frontrunning attack.

Expected Behavior

I don't have complete knowledge of the codebase but it's worth double checking especially if USDT or similar tokens are supposed to be handled.

Actual Behavior

On the second deposit the call will revert.

Possible Solution

Use forceApprove from OZ.