Conversation
Contributor
|
❤️ |
jalextowle
added a commit
that referenced
this pull request
Jun 11, 2023
Merged
jalextowle
added a commit
that referenced
this pull request
Jun 13, 2023
* Added negative interest checks and worked on calculating extreme values * Partially solved the calculate maximum long optimization problem * Implemented a working `calculateMaxLong` * Polished `calculateMaxLong` * Improved the tests for `calculateMaxShort` * Added unit tests for the negative interest checks * Special cased the scenario when the reserves are empty for negative interest * Improved the documentation of `calculateMaxLong` and `calculateMaxShort` * Minor `calculateMaxLong` fix * Added testing for the issue with `calculateSharesInGivenBondsOut` from Certora * Improved the test for Certora Question Week #1 (E) * Potential fix for intermittent failure of the "Benchmark" Github action * Return the bond amount in `calculateMaxLong` * Added a `calculateMaxBuy` function to `YieldSpaceMath` * Addressed Certora Question Week #4 A.2 * Addressed Certora Question Week #4 A.1 * Addressed review feedback from @jrhea
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h/t @MazyGio