testnet/devnet image using hardhat deploy#1034
Merged
Conversation
mcclurejt
force-pushed
the
mcclurejt/hardhat-docker-integration
branch
from
b6e7101 to
4804ebd
Compare
jalextowle
reviewed
May 21, 2024
jalextowle
reviewed
May 21, 2024
jalextowle
reviewed
May 21, 2024
jalextowle
reviewed
May 21, 2024
jalextowle
approved these changes
May 21, 2024
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
Nice job dude! LGTM once the style is updated. I'm assuming this has been tested, but if not, it would be good to do some smoke testing to make sure that it will #justwork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description